Skip to content

chore(deps): update dependency node to v22 #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22
16 changes: 8 additions & 8 deletions examples/nextjs-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/nextjs-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@ui5/webcomponents": "2.3.0",
"@ui5/webcomponents-fiori": "2.3.0",
"@ui5/webcomponents-react": "2.3.2",
"@types/node": "20.17.3",
"@types/node": "22.8.4",
"@types/react": "18.3.12",
"@types/react-dom": "18.3.1",
"eslint": "8.57.1",
Expand Down
16 changes: 8 additions & 8 deletions examples/nextjs-pages/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/nextjs-pages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@ui5/webcomponents": "2.3.0",
"@ui5/webcomponents-fiori": "2.3.0",
"@ui5/webcomponents-react": "2.3.2",
"@types/node": "20.17.3",
"@types/node": "22.8.4",
"@types/react": "18.3.12",
"@types/react-dom": "18.3.1",
"eslint": "8.57.1",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@testing-library/cypress": "^10.0.0",
"@types/eslint__js": "^8.42.3",
"@types/jscodeshift": "^0.12.0",
"@types/node": "^20.0.0",
"@types/node": "^22.0.0",
"@types/react": "^18.3.4",
"@types/react-dom": "^18.3.0",
"@types/use-sync-external-store": "^0.0.6",
Expand Down
3 changes: 1 addition & 2 deletions packages/base/src/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
export const deprecationNotice = (component: string, message: string) => {
if (process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test') {
const value = `*** ui5-webcomponents-react Deprecation Notice - ${component} ***\n`;
// eslint-disable-next-line no-console

if (console && console.warn) {
// eslint-disable-next-line no-console
console.warn(`${value}${message}`);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ interface ComparisonLine {
layout: 'vertical' | 'horizontal';
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
export const ComparisonLine = (props: ComparisonLine) => {
const { x, y, width, height, index, fill, strokeWidth, layout } = props;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ const ColumnChartWithTrend = forwardRef<HTMLDivElement, ColumnChartWithTrendProp
(currLine) => currLine.type === 'line' && currLine.accessor === tooltipProps.dataKey
);
if (line) {
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
return line.formatter(tooltipProps.payload[`__${line.accessor}`]);
}
const column = columnMeasures.find((currLine) => currLine.accessor === tooltipProps.dataKey);
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/bin/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ switch (command) {
const createWrapperModule = await import('../scripts/create-wrappers/main.js');

const outDir = resolve(process.cwd(), values.out!);
// eslint-disable-next-line @typescript-eslint/await-thenable

await createWrapperModule.default(packageName!, outDir, { additionalComponentNote });
break;
}
Expand Down Expand Up @@ -117,7 +117,7 @@ switch (command) {
process.exit(1);
}
const codemod = await import('../scripts/codemod/main.js');
await codemod.default(values.transform!, values.src!, values.typescript!);
await codemod.default(values.transform!, values.src!, values.typescript);
break;
}
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ export const VirtualTableBody = (props: VirtualTableBodyProps) => {
: rowVirtualizer.measureElement;

return (
// eslint-disable-next-line react/jsx-key
<div
key={key}
{...rowProps}
Expand Down Expand Up @@ -271,7 +270,6 @@ export const VirtualTableBody = (props: VirtualTableBodyProps) => {
}

return (
// eslint-disable-next-line react/jsx-key
<div
key={key}
{...allCellProps}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/components/AnalyticalTable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -577,11 +577,11 @@ const AnalyticalTable = forwardRef<AnalyticalTableDomRef, AnalyticalTablePropTyp
display: 'flex',
flexDirection: 'column'
};
if (!!rowHeight) {
if (rowHeight) {
tableStyles['--_ui5wcr-AnalyticalTableRowHeight'] = `${rowHeight}px`;
tableStyles['--_ui5wcr-AnalyticalTableHeaderRowHeight'] = `${rowHeight}px`;
}
if (!!headerRowHeight) {
if (headerRowHeight) {
tableStyles['--_ui5wcr-AnalyticalTableHeaderRowHeight'] = `${headerRowHeight}px`;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ export const IdentifyInputEventOrigin: Story = {
render(args) {
const [origin, setOrigin] = useState('');
const handleInput = (e) => {
if (!!e.currentTarget.parentElement.dataset.inFilterBar) {
if (e.currentTarget.parentElement.dataset.inFilterBar) {
setOrigin('FilterBar');
} else {
setOrigin('Filters Dialog');
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/ObjectPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
const lastSubSectionOrSection = lastSubSection ?? sectionElement.target;
if ((currentTabModeSection && !lastSubSection) || (sectionNodes.length === 1 && !lastSubSection)) {
setSectionSpacer(0);
} else if (!!tabContainerContainer) {
} else if (tabContainerContainer) {
setSectionSpacer(
objectPage.getBoundingClientRect().bottom -
tabContainerContainer.getBoundingClientRect().bottom -
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/internal/MessageViewContext.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createContext } from 'react';

export const MessageViewContext = createContext({
// eslint-disable-next-line @typescript-eslint/no-unused-vars
selectMessage: (_message: any) => {}
});
1 change: 0 additions & 1 deletion packages/main/src/internal/VariantManagementContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ export interface SelectedVariant extends VariantItemPropTypes {
}

export const VariantManagementContext = createContext({
// eslint-disable-next-line @typescript-eslint/no-unused-vars
selectVariantItem: (_selectedVariant: SelectedVariant) => {}
});
16 changes: 8 additions & 8 deletions templates/nextjs-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion templates/nextjs-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@ui5/webcomponents": "2.3.0",
"@ui5/webcomponents-fiori": "2.3.0",
"@ui5/webcomponents-react": "2.3.2",
"@types/node": "20.17.3",
"@types/node": "22.8.4",
"@types/react": "18.3.12",
"@types/react-dom": "18.3.1",
"eslint": "8.57.1",
Expand Down
16 changes: 8 additions & 8 deletions templates/nextjs-pages/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion templates/nextjs-pages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@ui5/webcomponents": "2.3.0",
"@ui5/webcomponents-fiori": "2.3.0",
"@ui5/webcomponents-react": "2.3.2",
"@types/node": "20.17.3",
"@types/node": "22.8.4",
"@types/react": "18.3.12",
"@types/react-dom": "18.3.1",
"eslint": "8.57.1",
Expand Down
18 changes: 1 addition & 17 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5370,15 +5370,6 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^20.0.0":
version: 20.17.1
resolution: "@types/node@npm:20.17.1"
dependencies:
undici-types: "npm:~6.19.2"
checksum: 10c0/214cf1fffff9c80ae0d49d7dd1f04254215d49711276fff44ff6f61e36dc8d53520509a88add6955fe029b2259c87eaf284b43bc1236d4f4f06bd80c46f0e2b8
languageName: node
linkType: hard

"@types/normalize-package-data@npm:^2.4.0":
version: 2.4.1
resolution: "@types/normalize-package-data@npm:2.4.1"
Expand Down Expand Up @@ -21394,7 +21385,7 @@ __metadata:
"@testing-library/cypress": "npm:^10.0.0"
"@types/eslint__js": "npm:^8.42.3"
"@types/jscodeshift": "npm:^0.12.0"
"@types/node": "npm:^20.0.0"
"@types/node": "npm:^22.0.0"
"@types/react": "npm:^18.3.4"
"@types/react-dom": "npm:^18.3.0"
"@types/use-sync-external-store": "npm:^0.0.6"
Expand Down Expand Up @@ -21474,13 +21465,6 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~6.19.2":
version: 6.19.6
resolution: "undici-types@npm:6.19.6"
checksum: 10c0/9b2264c5700e7169c6c62c643aac56cd8984c5fd7e18ed31ff11780260e137f6340dee8317a2e6e0ae3c49f5e5ef6fa577ea07193cbaa535265cba76a267cae9
languageName: node
linkType: hard

"undici-types@npm:~6.19.8":
version: 6.19.8
resolution: "undici-types@npm:6.19.8"
Expand Down
Loading