Skip to content

rewrite page test #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2020
Merged

rewrite page test #818

merged 2 commits into from
Oct 23, 2020

Conversation

sidram05
Copy link
Contributor

@sidram05 sidram05 commented Oct 23, 2020 •
edited
Loading

transition from enzyme to react-testing-library

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@sidram05
rewrite page test
39d867e 
transition from enzyme to react-testing-library
@MarcusNotheis MarcusNotheis linked an issue Oct 23, 2020 that may be closed by this pull request
rewrite Page test using react-testing-library #759
Closed
@coveralls
Copy link

coveralls commented Oct 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 65.448% when pulling 14da0f5 on sidram05:Page-Test-Update into 11c8684 on SAP:master.

@MarcusNotheis MarcusNotheis merged commit fa1fd81 into SAP:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusNotheis MarcusNotheis MarcusNotheis approved these changes

@Lukas742 Lukas742 Awaiting requested review from Lukas742

@vbersch vbersch Awaiting requested review from vbersch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rewrite Page test using react-testing-library
3 participants
@sidram05 @coveralls @MarcusNotheis