Skip to content

docs: update migration guide #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2020
Merged

docs: update migration guide #927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c6b13b
docs: update migration guide
MarcusNotheis Nov 10, 2020
4bef814
Merge branch 'master' into docs/migration-guide-spinner
Lukas742 Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions docs/2-MigrationGuide.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,41 @@ or the [changelog](https://github.com/SAP/ui5-webcomponents-react/blob/master/CH

<br />

### Updated import paths for `icons`

All icons imports are changed. The individual icons modules are available in the icon package's `dist` folder.
If you previously had `import "@ui5/webcomponents-icons/dist/icons/accept.js"`, now it becomes `import "@ui5/webcomponents-icons/dist/accept.js";`.

<br />

### API Updates

The `Toolbar` was firing an event `onToolbarClick`. This event has been replaced with `onClick`.

<br />

### Deleted Components

<br />

#### Spinner

The deprecated `Spinner` component has been removed in favor of the [BusyIndicator](https://sap.github.io/ui5-webcomponents-react/?path=/docs/ui5-web-components-busyindicator) component.

Migration Example:

```jsx
<Spinner size={Size.Large} delay={1000} />
```

will become

```jsx
<BusyIndicator size={BusyIndicatorSize.Large} active />
```

#### Tokenizer

The deprecated `Tokenizer` component has been removed in favor of the [MultiInput](https://sap.github.io/ui5-webcomponents-react/?path=/docs/ui5-web-components-multiinput) component.

Migration Example:
Expand Down