-
Notifications
You must be signed in to change notification settings - Fork 14
Handle images with odd dimensions and fix color matrix, and add CI to check decoding functions #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle images with odd dimensions and fix color matrix, and add CI to check decoding functions #9
Conversation
Hi. Nice to see your contribution again. I’ll have a check tomorrow, the CI integration is good (Previously, because of lack of unit test, I just use the Example samples). A CLI for macOS is OK, we can also use the same test cases like SDWebImage or SDWebImageWebPCoder as well, which is much better for Xcode and can collect code coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change part LGTM +1.
The CI runner part, what else should I do to turn on GitHub Actions ? I previouslly only use the Travis-CI to build Unit Test.
Let me just merge and have a try ? |
Thank you for your review! (and sorry for the late reply...)
I agree. If you need, I will create some additional test images (which are more simple to write unit tests).
Just put yaml files to
Of course! After this patch will be merged, Github Actions will be turned on. |
Hi!
I found some bugs, and fixed:
And also, I added automated tests using github actions, because it is very boring and hard to check all cases by hand.
It checks that:
Result page is here:
https://github.com/link-u/SDWebImageAVIFCoder/actions/runs/34667715
If travis-ci is more appropriate, I will port it.
Please take a look!