Skip to content

Add a missing dispatch #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Add a missing dispatch #204

merged 3 commits into from
Apr 26, 2023

Conversation

ChrisRackauckas
Copy link
Member

@avik-pal this needs fmap and thus a Functors.jl dependency. Could that be avoided somehow or is it necessary? I would guess you could turn it into a componentarray and then apply backing?

@avik-pal this needs `fmap` and thus a Functors.jl dependency. Could that be avoided somehow or is it necessary? I would guess you could turn it into a componentarray and then apply `backing`?
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #204 (572d694) into master (02c95fe) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   73.46%   73.14%   -0.32%     
==========================================
  Files          20       20              
  Lines         686      689       +3     
==========================================
  Hits          504      504              
- Misses        182      185       +3     
Impacted Files Coverage Δ
src/ComponentArrays.jl 88.88% <ø> (ø)
src/compat/chainrulescore.jl 64.28% <0.00%> (-17.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avik-pal
Copy link
Member

Functors is an extremely lightweight dependency (it literally just depends on LinearAlgebra).

I would guess you could turn it into a componentarray and then apply backing?

That was my first attempt. But Tangent is not an AbstractArray so CA wouldn't flatten it.

@jonniedie
Copy link
Collaborator

Functors is an extremely lightweight dependency (it literally just depends on LinearAlgebra).

That should be fine, then.

@ChrisRackauckas
Copy link
Member Author

This should be good to go now. Fixes the last bug in SciML/SciMLSensitivity.jl#818

@jonniedie jonniedie merged commit c2abc16 into SciML:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants