Parse constants in @mtkmodel
#2499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run format. |
ven-k
force-pushed
the
vkb/constant-in-mtkmodel
branch
2 times, most recently
from
7316a00 to
9775675
Compare
ven-k
force-pushed
the
vkb/constant-in-mtkmodel
branch
from
9775675 to
60fa733
Compare
Allows `@constants` in the `@mtkmodel`; this works similar to the `@constants`; and in addition, a type check is added to the assigned value.
Adds top-level and the closed module tests.
ven-k
force-pushed
the
vkb/constant-in-mtkmodel
branch
from
60fa733 to
7c377de
Compare
|
@ChrisRackauckas this is ready. Model Parsing tests have passed: https://github.com/SciML/ModelingToolkit.jl/actions/runs/8131018586/job/22219887461?pr=2499#step:6:1309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
@constantsin the@mtkmodel; this works similar to the@constants; and in addition, a type check is added to the assigned value.Closes #2362
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.