Skip to content

🚑 pass type to var generation #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Feb 29, 2024

Missing piece of #2500.

This ensures the parameters and variables are of specified type.
Adds extra tests for checking symtype.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ven-k ven-k marked this pull request as draft February 29, 2024 10:55
@ven-k ven-k marked this pull request as ready for review February 29, 2024 10:57
@ven-k
Copy link
Member Author

ven-k commented Feb 29, 2024

@ChrisRackauckas ChrisRackauckas merged commit 78ec2b2 into SciML:master Feb 29, 2024
@ven-k ven-k deleted the vkb/datatype-fix branch February 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants