feat: add SolverStepClock
#2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
force-pushed
the
fb/continuousclock
branch
from
4e56e33 to
2d4668d
Compare
|
The name is a bit odd. Call it a StepClock? |
|
Step itself is not a super descriptive name, ContinuousClock was inspired by what simulink/stateflow calls "continuous sample time" |
|
SolverStepClock is good. |
ChrisRackauckas
approved these changes
Mar 4, 2024
|
Fails tests |
A ContinuousClock ticks at every solver step change name to `SolverStepClock` update docstring change clock name in codegen
baggepinnen
force-pushed
the
fb/continuousclock
branch
from
f15e165 to
7835e94
Compare
|
I think the remaining test failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ContinuousClock ticks at every solver step
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This allows using discrete-time systems that are triggered at each solver step, useful to model discrete stateful behavior attached to continuous events.