fix: fix io handling in structural_simplify, input_output_handling tests #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
baggepinnen
approved these changes
Mar 14, 2024
AayushSabharwal
force-pushed
the
as/fix-io
branch
from
e82e146 to
dbbb205
Compare
|
Doc failure is just codecov being codecov |
AayushSabharwal
force-pushed
the
as/fix-io
branch
from
dbbb205 to
33c5b1c
Compare
Comment on lines
878
to
882
| if u0map isa Dict | ||
| trueinit = identity.([zerovars; collect(pairs(u0map))]) | ||
| else | ||
| trueinit = identity.([zerovars; u0map]) | ||
| end |
There was a problem hiding this comment.
Shouldn't this just be trueinit = merge(zerovars, todict(u0map))?
There was a problem hiding this comment.
Fixed in c428591
AayushSabharwal
force-pushed
the
as/fix-io
branch
from
33c5b1c to
c428591
Compare
|
Tests fail |
AayushSabharwal
force-pushed
the
as/fix-io
branch
from
c428591 to
a3320d9
Compare
AayushSabharwal
force-pushed
the
as/fix-io
branch
from
a3320d9 to
75465f6
Compare
|
Tests are fine now, it's just the Optimization thing that's new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.