refactor: use the t defined in the module
#2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Mar 25, 2024
|
tests fail? |
ChrisRackauckas
approved these changes
Mar 25, 2024
ven-k
commented
Mar 25, 2024
| @@ -94,5 +94,3 @@ end | |||
| @safetestset "BifurcationKit Extension Test" include("extensions/bifurcationkit.jl") | |||
| end | |||
| end | |||
|
|
|||
| @safetestset "Model Parsing Test" include("model_parsing.jl") | |||
There was a problem hiding this comment.
Removed as this is duplicate of this test: https://github.com/SciML/ModelingToolkit.jl/pull/2569/files#diff-3b9314a6f9f2d7eec1d0ef69fa76cfabafdbe6d0df923768f9ec32f27a249c63R47
|
The test failure seems real. |
`t` is now available in three flavours. Thus, allow a downstream package to import the appropriate one, and use that to define the mtk-models.
|
Model Parsing Tests pass now: https://github.com/SciML/ModelingToolkit.jl/actions/runs/8506330803/job/23296377185?pr=2569#step:6:1422 |
+ Adds an indirect test which validates units and check that metadata is correctly set.
|
While here, I've improved tests for constants (and it's metadata) in mtkmodel. @ChrisRackauckas the model parsing tests are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tis now available in three flavours. Thus, allow a downstream package to import the appropriate one, and use that to define variables in the mtk-models.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.