feat: implement SII.remake_buffer for MTKParameters, fix bugs, add tests #2570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this supposed to fix #2571? Can we get a direct test on that behavior? |
Comment on lines
+95
to
+103
| ps = MTKParameters(sys, ivs) | ||
| function loss(value, sys, ps) | ||
| @test value isa ForwardDiff.Dual | ||
| vals = merge(Dict(parameters(sys) .=> getp(sys, parameters(sys))(ps)), Dict(a => value)) | ||
| ps = remake_buffer(sys, ps, vals) | ||
| getp(sys, a)(ps) + getp(sys, b)(ps) | ||
| end | ||
|
|
||
| @test ForwardDiff.derivative(x -> loss(x, sys, ps), 1.5) == 3.0 |
There was a problem hiding this comment.
what about a test that actually uses remake?
There was a problem hiding this comment.
remake doesn't use remake_buffer yet so that would just fail. I've planned refactoring remake for after this since without it remake would fail for all MTK problems
AayushSabharwal
force-pushed
the
as/remake-hook
branch
from
bcc5015 to
3edb635
Compare
AayushSabharwal
force-pushed
the
as/remake-hook
branch
from
562c88c to
e476efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2571
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.