Skip to content

fix: fix variable namespacing issues #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AayushSabharwal
Copy link
Member

Close #2344
Close #2252
Close #2477

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal force-pushed the as/fix-namespacing-defaults branch from ba29b83 to 134c33e Compare April 2, 2024 13:49
@ChrisRackauckas
Copy link
Member

Some test failures

@AayushSabharwal AayushSabharwal force-pushed the as/fix-namespacing-defaults branch 2 times, most recently from 88463c4 to 5173938 Compare April 5, 2024 14:30
@AayushSabharwal AayushSabharwal force-pushed the as/fix-namespacing-defaults branch from c4469ba to cfe093e Compare April 11, 2024 10:16
@AayushSabharwal AayushSabharwal force-pushed the as/fix-namespacing-defaults branch from cfe093e to 8ef7908 Compare April 16, 2024 07:21
@ChrisRackauckas ChrisRackauckas merged commit 709148e into SciML:master Apr 16, 2024
@AayushSabharwal AayushSabharwal deleted the as/fix-namespacing-defaults branch April 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants