fix: fix callback codegen, observed eqs with non-scalarized symbolic arrays #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/fix-array-observed
branch
from
a0eb3d4 to
a4628af
Compare
This was referenced Apr 4, 2024
|
The ODESystem failure is weird, but what confuses me more is how Downstream tests decided to start working all of a sudden 😆 |
AayushSabharwal
force-pushed
the
as/fix-array-observed
branch
from
0717ef7 to
831f34d
Compare
This needs to be fixed by Symbolics
AayushSabharwal
force-pushed
the
as/fix-array-observed
branch
from
a02fb6e to
4047e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2599
Close #2383
Close #1283
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.