Skip to content

fix: propagate parameter dependencies in extend #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2024
Merged

fix: propagate parameter dependencies in extend #2629

merged 3 commits into from
Apr 12, 2024

Conversation

SebastianM-C
Copy link
Contributor

@SebastianM-C SebastianM-C commented Apr 10, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

It looks like parameter_dependencies are not propagated when extending the system.

@ChrisRackauckas
Copy link
Member

Needs a test

AayushSabharwal
AayushSabharwal reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to the PR, but might as well fix it

@SebastianM-C
Copy link
Contributor Author

Tests fail because nonlinear systems don't have parameter dependencies. Are they expected to have that?

@AayushSabharwal
Copy link
Member

I didn't add parameter dependencies to nonlinear systems because it didn't seem necessary. Can parameters change while solving a NonlinearProblem? Or do we still want them so that the dependent parameter is always calculated as a function of the other parameters every time the problem is created?

@ChrisRackauckas
Copy link
Member

The latter

@AayushSabharwal
Copy link
Member

#2632 needs to be merged for CI to pass here then

@ChrisRackauckas
Copy link
Member

Rebase

@SebastianM-C
Copy link
Contributor Author

I'm not sure why the integration tests fail, it looks unrelated to this PR.

@ChrisRackauckas ChrisRackauckas merged commit 3847ec6 into SciML:master Apr 12, 2024
@SebastianM-C SebastianM-C deleted the extend branch April 12, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushSabharwal AayushSabharwal AayushSabharwal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianM-C @ChrisRackauckas @AayushSabharwal