error for hybrid continuous/discrete systems #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @test_nowarn solve(prob, Tsit5(); kwargshandle = KeywordArgSilent) | ||
|
|
||
| @mtkbuild sys = ODESystem(eqs, t; parameter_dependencies = [kq => 2kp], | ||
| discrete_events = [[0.5] => [kp ~ 2.0]]) |
There was a problem hiding this comment.
I thought directly defined events were fine? What's the issue here?
There was a problem hiding this comment.
The equations used here are still clocked, this test adds a manually defined discrete event in addition to the clocked system
ChrisRackauckas
approved these changes
Jun 5, 2024
|
Handle the typos first. |
YingboMa
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects hybrid continuous/discrete systems and throws an error indicating that they are not yet supported by the default MTK compiler, indicating that JuliaSimCompiler is currently required for correctness.
The tests are also deactivated.