feat: complete eval_expression and eval_module support
#2826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jun 28, 2024
AayushSabharwal
force-pushed
the
as/m-e-g-a
branch
from
9e417c4 to
9aaa126
Compare
|
The inference failures are weird, even Cthulhu output doesn't make sense. |
ChrisRackauckas
added a commit
to bradcarman/ActiveSuspensionModel
that referenced
this pull request
Jun 29, 2024
I tested solver precompile and it worked just fine: ```julia using ActiveSuspensionModel, OrdinaryDiffEq sys = ActiveSuspensionModel.prob.f.sys; @time sol = solve(ActiveSuspensionModel.prob; dtmax=0.1); ``` ```julia 0.007036 seconds (18.07 k allocations: 1.066 MiB, 72.30% compilation time) ``` Of course as mentioned there's the issue with ```julia @time prob′ = remake(ActiveSuspensionModel.prob, p = [sys.gravity => 1.0]) ``` which is the completion SciML/ModelingToolkit.jl#2826.
AayushSabharwal
force-pushed
the
as/m-e-g-a
branch
from
9aaa126 to
add87d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.