Skip to content

allow the user to override the default smoothing parameter for sources #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

baggepinnen
Copy link
Contributor

No description provided.

@baggepinnen baggepinnen requested a review from ven-k January 27, 2023 06:05
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #146 (13d8827) into main (a99c4cc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   67.51%   67.48%   -0.03%     
==========================================
  Files          33       33              
  Lines        1499     1498       -1     
==========================================
- Hits         1012     1011       -1     
  Misses        487      487              
Impacted Files Coverage Δ
src/Blocks/sources.jl 92.38% <100.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ven-k
Copy link
Member

ven-k commented Jan 27, 2023

Changes LGTM.

But wouldn't it be better if

  1. We have dispatches based on smooth - Int or Bool?
    Or
  2. Just have another var δ or `smooth_coef``

@baggepinnen
Copy link
Contributor Author

  1. You cannot dispatch on keyword arguments, and the workaround to do so makes the code very bloated
  2. I didn't want two different arguments to handle the same thing, both of which must be set to achieve a change in smoothness factor
  3. I don't want to break the existing interface.

I think this solution was a good tradeoff

@baggepinnen baggepinnen merged commit 880cd09 into main Jan 28, 2023
@jebej
Copy link

jebej commented Jan 28, 2023

Doesn’t this change make those functions type unstable when smooth::Bool?

@baggepinnen
Copy link
Contributor Author

They do, but the output is a symbolical expression, which is type unstable anyways so what does it matter?

@baggepinnen baggepinnen deleted the fb/smooth branch January 29, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants