Skip to content

fix Td definition in LimPID #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix Td definition in LimPID #152

merged 2 commits into from
Mar 30, 2023

Conversation

baggepinnen
Copy link
Contributor

somewhere the original implementation got inverted

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #152 (9372faf) into main (610b936) will decrease coverage by 41.52%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #152       +/-   ##
===========================================
- Coverage   69.57%   28.05%   -41.52%     
===========================================
  Files          35       35               
  Lines        1558     1561        +3     
===========================================
- Hits         1084      438      -646     
- Misses        474     1123      +649     
Impacted Files Coverage Δ
src/Blocks/continuous.jl 18.56% <0.00%> (-79.66%) ⬇️
src/Electrical/Digital/logic_vectors.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Mechanical/Translational/sources.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Mechanical/TranslationalPosition/sources.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Magnetic/FluxTubes/utils.jl 0.00% <0.00%> (-90.00%) ⬇️
src/Electrical/Digital/tables.jl 0.00% <0.00%> (-84.91%) ⬇️
src/Thermal/HeatTransfer/sources.jl 0.00% <0.00%> (-80.77%) ⬇️
src/Mechanical/Rotational/sensors.jl 21.73% <0.00%> (-78.27%) ⬇️
src/Blocks/sources.jl 16.51% <0.00%> (-75.87%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@baggepinnen
Copy link
Contributor Author

CI failure looks unrelated, master appears to fail as well

@YingboMa YingboMa merged commit 1e267db into main Mar 30, 2023
@YingboMa YingboMa deleted the fb/pid_Td branch March 30, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants