Input changed to SampledData #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 59.59% 59.23% -0.36%
==========================================
Files 41 42 +1
Lines 2027 2068 +41
==========================================
+ Hits 1208 1225 +17
- Misses 819 843 +24
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
baggepinnen
reviewed
May 3, 2023
src/Blocks/sources.jl
Outdated
Comment on lines
565
to
566
| defaults = [output.u => get_sampled_data(0.0, buffer)]) #TODO: get initial value from buffer | ||
| end |
There was a problem hiding this comment.
Suggested change
| defaults = [output.u => get_sampled_data(0.0, buffer)]) #TODO: get initial value from buffer | |
| end | |
| defaults = [output.u => get_sampled_data(0.0, buffer)]) #TODO: get initial value from buffer | |
| end | |
| @deprecate Input SampledData |
Since a release was made with the Input name, we should avoid breaking it completely.
YingboMa
reviewed
May 4, 2023
|
|
||
| This component is easy to use and is performative. However the data is locked to the `ODESystem` and can only be changed by building a new `ODESystem`. Therefore, running a batch of data would not be efficient. Below is an example of how to use the `TimeVaryingFunction` with `DataInterpolations` to build the function from discrete data. | ||
| The `ModelingToolkitStandardLibrary.Blocks.TimeVaryingFunction` component is easy to use and is performative. However the data is locked to the `ODESystem` and can only be changed by building a new `ODESystem`. Therefore, running a batch of data would not be efficient. Below is an example of how to use the `TimeVaryingFunction` with `DataInterpolations` to build the function from sampled discrete data. |
There was a problem hiding this comment.
performative -> performant maybe?
YingboMa
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.