Fixes to test suite #174
Merged
Fixes to test suite #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 66.16% 59.37% -6.80%
==========================================
Files 55 55
Lines 2001 2230 +229
==========================================
Hits 1324 1324
- Misses 677 906 +229 see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
staticfloat
force-pushed
the
sf/test_fixes
branch
from
06f1af9 to
495e2a7
Compare
YingboMa
reviewed
May 19, 2023
Tearing could choose to solve for `-v` instead of `v`, so use the observable API rather than assuming what tearing does.
staticfloat
force-pushed
the
sf/test_fixes
branch
from
495e2a7 to
6281c99
Compare
|
I've dropped the |
staticfloat
force-pushed
the
sf/test_fixes
branch
from
6281c99 to
ef7dd96
Compare
YingboMa
approved these changes
May 31, 2023
oxinabox
pushed a commit
to staticfloat/ModelingToolkitStandardLibrary.jl
that referenced
this pull request
Oct 2, 2023
staticfloat
added a commit
to staticfloat/ModelingToolkitStandardLibrary.jl
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of fixes to the test suite that should be always desirable. In a separate PR, I have collected fixes that may not be desirable, but are required for running with DAECompiler.