Bgc/negative pressure #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2023 11:10
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 60.18% 59.43% -0.76%
==========================================
Files 55 55
Lines 2170 2226 +56
==========================================
+ Hits 1306 1323 +17
- Misses 864 903 +39
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
YingboMa
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physically it doesn't make sense for hydraulic gauge pressure to go negative, and if it does this would lead to boiling the fluid. This feature adds the ability to calculate an approximate correct density to simulate liquid to gas transition and give a more accurate model for cases when this might happen.