Skip to content

remove broken link #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023
Merged

remove broken link #183

merged 3 commits into from
May 31, 2023

Conversation

bradcarman
Copy link
Contributor

No description provided.

@@ -28,7 +28,6 @@ The following are the constituant libraries of the ModelingToolkit Standard Libr
- [Electrical Components](https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/API/electrical/)
- [Magnetic Components](https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/API/magnetic/)
- [Thermal Components](https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/API/thermal/)
- [Hydraulic Components](https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/API/hydraulic/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all use refs instead of direct links.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #183 (485e287) into main (102c6f0) will decrease coverage by 6.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   66.16%   59.37%   -6.80%     
==========================================
  Files          55       55              
  Lines        2001     2230     +229     
==========================================
  Hits         1324     1324              
- Misses        677      906     +229     
Impacted Files Coverage Δ
src/Hydraulic/IsothermalCompressible/utils.jl 69.49% <ø> (-25.86%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YingboMa YingboMa marked this pull request as ready for review May 31, 2023 19:26
@YingboMa YingboMa merged commit 5fafa79 into main May 31, 2023
@YingboMa YingboMa deleted the bgc/hydraulic_docs branch May 31, 2023 19:26
oxinabox pushed a commit to staticfloat/ModelingToolkitStandardLibrary.jl that referenced this pull request Oct 2, 2023
staticfloat pushed a commit to staticfloat/ModelingToolkitStandardLibrary.jl that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants