Skip to content

Parameter type optimizations #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Parameter type optimizations #186

merged 7 commits into from
Jun 22, 2023

Conversation

bradcarman
Copy link
Contributor

  • removed extra n::Int parameter
  • verified derivative formulation is correct
  • extra code for potential AE hack implementation

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #186 (46985fc) into main (672c96c) will decrease coverage by 7.91%.
The diff coverage is 31.81%.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   66.16%   58.26%   -7.91%     
==========================================
  Files          55       55              
  Lines        2001     2288     +287     
==========================================
+ Hits         1324     1333       +9     
- Misses        677      955     +278     
Impacted Files Coverage Δ
src/Blocks/sources.jl 70.45% <25.00%> (-13.16%) ⬇️
src/Mechanical/Translational/utils.jl 37.50% <33.33%> (-37.50%) ⬇️
src/Mechanical/Translational/sources.jl 47.05% <38.09%> (-34.76%) ⬇️
src/Hydraulic/IsothermalCompressible/components.jl 48.81% <50.00%> (-42.33%) ⬇️
src/Mechanical/Translational/components.jl 49.31% <100.00%> (-12.76%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YingboMa YingboMa merged commit 77d57f0 into main Jun 22, 2023
@YingboMa YingboMa deleted the bgc/ae_hack branch June 22, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants