Skip to content

Improve type stability of basic sources #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

oxinabox
Copy link
Contributor

This is pretty minor, as these type instabilities in ifelse are taken care of by union-splitting anyway.
But I did notice them, so thought i would fix

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.40%. Comparing base (02a134c) to head (15da497).

Files Patch % Lines
src/Blocks/sources.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   61.82%   54.40%   -7.42%     
==========================================
  Files          46       46              
  Lines        1438     1634     +196     
==========================================
  Hits          889      889              
- Misses        549      745     +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Contributor Author

CodeCov is wrong afaict

@ChrisRackauckas ChrisRackauckas merged commit 37faf7b into SciML:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants