Skip to content

Switch defaults for guesses for some components #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024

Conversation

SebastianM-C
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

With MTK@v9 the defaults act as equations duing initialization, which can lead to overconstrained systems that can't be solved in some cases.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.29%. Comparing base (37faf7b) to head (ab38d19).
Report is 18 commits behind head on main.

❗ Current head ab38d19 differs from pull request most recent head 39f5098. Consider uploading reports for the commit 39f5098 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   61.53%   54.29%   -7.24%     
==========================================
  Files          46       46              
  Lines        1448     1641     +193     
==========================================
  Hits          891      891              
- Misses        557      750     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianM-C SebastianM-C marked this pull request as ready for review May 8, 2024 13:16
@SebastianM-C SebastianM-C reopened this May 8, 2024
@ChrisRackauckas ChrisRackauckas merged commit 76b07b3 into SciML:main May 10, 2024
4 of 9 checks passed
@SebastianM-C SebastianM-C deleted the smc/guess branch May 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants