Skip to content

Analysis point fixes #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Analysis point fixes #298

merged 1 commit into from
May 30, 2024

Conversation

baggepinnen
Copy link
Contributor

This PR fixes a few things related to analysis points

  • Handle loop openings in same analysis point as input or output
  • Fix for analysis points in systems with units
  • utility to print all existing analysis points

cc @shobhitvoleti

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.58%. Comparing base (200b13a) to head (00601f2).

Files Patch % Lines
src/Blocks/analysis_points.jl 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   61.56%   54.58%   -6.99%     
==========================================
  Files          46       46              
  Lines        1470     1680     +210     
==========================================
+ Hits          905      917      +12     
- Misses        565      763     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit 3ae7030 into main May 30, 2024
4 of 9 checks passed
@baggepinnen baggepinnen deleted the fb/ap_updates branch May 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant