Skip to content

Make thermal models ODEs again #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2022

Conversation

ValentinKaisermayer
Copy link
Contributor

@ValentinKaisermayer ValentinKaisermayer commented Jun 10, 2022

Breaking Changes:

  • Renames ports of ConvectiveResistor (solidport to solid and fluidport to fluid) to be the same as ConvectiveConductor.

New Components:

  • PrescribedHeatFlow
  • PrescribedTemperature

@ValentinKaisermayer
Copy link
Contributor Author

Closes #1

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #73 (0b09f65) into main (538fb2b) will increase coverage by 0.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   69.06%   69.42%   +0.36%     
==========================================
  Files          23       23              
  Lines         931      942      +11     
==========================================
+ Hits          643      654      +11     
  Misses        288      288              
Impacted Files Coverage Δ
src/Thermal/utils.jl 90.00% <ø> (ø)
src/Thermal/HeatTransfer/ideal_components.jl 100.00% <100.00%> (ø)
src/Thermal/HeatTransfer/sensors.jl 100.00% <100.00%> (ø)
src/Thermal/HeatTransfer/sources.jl 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ValentinKaisermayer
Copy link
Contributor Author

ValentinKaisermayer commented Jun 10, 2022

Resolves #57

renames ports (same as Modelica)
@ValentinKaisermayer ValentinKaisermayer marked this pull request as ready for review June 10, 2022 16:59
@ChrisRackauckas ChrisRackauckas requested a review from YingboMa June 11, 2022 02:38
@ChrisRackauckas ChrisRackauckas merged commit 24a442f into SciML:main Jun 19, 2022
@ValentinKaisermayer ValentinKaisermayer deleted the fix-der_T branch June 19, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants