Adds hydraulic library #78
Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 69.42% 69.34% -0.09%
==========================================
Files 23 26 +3
Lines 942 985 +43
==========================================
+ Hits 654 683 +29
- Misses 288 302 +14
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Works fine with smaller solver tolerance: |
|
Conflicts. Yes. looks like a standard numerical instability due to large dts. |
ValentinKaisermayer
force-pushed
the
hydraulic
branch
from
0efd202 to
eb22c76
Compare
|
@ValentinKaisermayer just curious: why are you modeling changes in density due to pressure but ignore temperature entirely? E.g. for water, 10K change in temperature is more significant than 10MPa change in pressure. |
|
Because this library is supposed to model fluid systems where the change in temperature is negligible. This allows to avoid stream connectors all together. However, if this is an insufficient assumption for the modeling needs at hand, a |
|
I guess this is obsolete with #159 |
There seems to be still an issue, maybe with the solver, I'm not sure.
The mass flow rate should get to zero when the pressure of the volume is equal to the pressure of the source.
Rodas4
Tsit5
Since many components need some sort of media properties, I used the variable scope to lift them into the overall model where they can be centrally defined. Maybe there is a better way to do this. Modelica and Simscape do this via a special block that is present in the model.