Standardized solution type in SciMLBase #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to add the uniform output (compatible with SciMLBase).
Closed
|
It's breaking because of the solution access change (which is tiny but still breaking downstream), so I'm calling this v1.0 because it's now inline with the rest of the SciML interfaces. We can of course continue to add more to the solution type, such as standardized ways for logging and improving the retcodes, but I think all of that should be extensions not breaking. |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 84.21% 87.46% +3.25%
==========================================
Files 3 3
Lines 361 351 -10
==========================================
+ Hits 304 307 +3
+ Misses 57 44 -13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.