Use the minimum with save_best in flux optimiser #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavdixit02
force-pushed
the
Vaibhavdixit02-patch-1
branch
from
52709aa to
de613ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 75.73% 75.82% +0.09%
==========================================
Files 31 31
Lines 1059 1063 +4
==========================================
+ Hits 802 806 +4
Misses 257 257
Continue to review full report at Codecov.
|
src/solve/flux.jl
Outdated
| @@ -53,10 +54,13 @@ function __solve(prob::OptimizationProblem, opt::AbstractFluxOptimiser, data = D | |||
| if first(x) < first(min_err) #found a better solution | |||
| min_opt = opt | |||
| min_err = x | |||
| min_θ = θ | |||
There was a problem hiding this comment.
You need to copy, otherwise it gets mutated.
Co-authored-by: Christopher Rackauckas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178