Skip to content

Automatically wrap Optim solver in Fminbox #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Automatically wrap Optim solver in Fminbox #184

merged 1 commit into from
Oct 19, 2021

Conversation

jonasmac16
Copy link
Contributor

This PR should fix both
#179
and
#172

It also adds a warning about SimulatedAnnealing() if constraints are defined

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right idea. Perfect!

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #184 (1177e8e) into master (91db6b4) will decrease coverage by 0.26%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   75.82%   75.55%   -0.27%     
==========================================
  Files          31       31              
  Lines        1063     1072       +9     
==========================================
+ Hits          806      810       +4     
- Misses        257      262       +5     
Impacted Files Coverage Δ
src/solve/optim.jl 88.59% <58.33%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91db6b4...1177e8e. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 3c2fd06 into SciML:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants