Skip to content

Create sub packages for each optimiser #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 25, 2022
Merged

Create sub packages for each optimiser #220

merged 22 commits into from
Apr 25, 2022

Conversation

Vaibhavdixit02
Copy link
Member

This PR changes the structure of the repo and stops use of Requires based loading, the supported optimiser backends will each now be a sub package.

@ChrisRackauckas
Copy link
Member

And we should make sure to add the tests for them too

@Vaibhavdixit02
Copy link
Member Author

Yes I am doing that as well

@ChrisRackauckas
Copy link
Member

Can you get to a place where tests pass and we can merge? Please don't do this in a way where every package has to be moved before the first PR can merge.

@Vaibhavdixit02
Copy link
Member Author

Can you get to a place where tests pass and we can merge? Please don't do this in a way where every package has to be moved before the first PR can merge.

I am not sure I understood? So right now I have moved Flux and BBO and their tests will pass (I haven't added it to CI and adjusted existing test files) so are you suggesting to do this incrementally in subsequent PRs?

@Vaibhavdixit02
Copy link
Member Author

In my opinion we should do it in this PR and bump to v2 since it would be a significant workflow change so doing it partially might not be ideal

@Vaibhavdixit02 Vaibhavdixit02 force-pushed the subpckgs branch 3 times, most recently from f519f30 to be04625 Compare April 18, 2022 10:35
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #220 (5c234ad) into master (6d0de7f) will decrease coverage by 17.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #220       +/-   ##
===========================================
- Coverage   62.37%   45.29%   -17.09%     
===========================================
  Files          31        8       -23     
  Lines        1119      170      -949     
===========================================
- Hits          698       77      -621     
+ Misses        421       93      -328     
Impacted Files Coverage Δ
src/GalacticOptim.jl 100.00% <ø> (ø)
src/utils.jl 33.33% <ø> (-5.70%) ⬇️
src/function/tracker.jl 0.00% <0.00%> (-100.00%) ⬇️
src/function/finitediff.jl 0.00% <0.00%> (-100.00%) ⬇️
src/function/reversediff.jl 0.00% <0.00%> (-95.46%) ⬇️
src/function/zygote.jl 52.17% <0.00%> (-43.29%) ⬇️
src/function/forwarddiff.jl 90.24% <0.00%> (-9.76%) ⬇️
...lutionStrategy/src/GalacticCMAEvolutionStrategy.jl
...b/GalacticEvolutionary/src/GalacticEvolutionary.jl
... and 15 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChrisRackauckas
Copy link
Member

All of the system-wide issues seem to be fixed, so I'm merging so that each of the per-package issues that are remaining can be handled separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants