-
-
Notifications
You must be signed in to change notification settings - Fork 96
Create sub packages for each optimiser #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And we should make sure to add the tests for them too |
Yes I am doing that as well |
Can you get to a place where tests pass and we can merge? Please don't do this in a way where every package has to be moved before the first PR can merge. |
I am not sure I understood? So right now I have moved Flux and BBO and their tests will pass (I haven't added it to CI and adjusted existing test files) so are you suggesting to do this incrementally in subsequent PRs? |
In my opinion we should do it in this PR and bump to v2 since it would be a significant workflow change so doing it partially might not be ideal |
f519f30
to
be04625
Compare
2d51c59
to
c2b5042
Compare
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
===========================================
- Coverage 62.37% 45.29% -17.09%
===========================================
Files 31 8 -23
Lines 1119 170 -949
===========================================
- Hits 698 77 -621
+ Misses 421 93 -328
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
All of the system-wide issues seem to be fixed, so I'm merging so that each of the per-package issues that are remaining can be handled separately. |
This PR changes the structure of the repo and stops use of Requires based loading, the supported optimiser backends will each now be a sub package.