Skip to content

Incorrect convert call for cons_hess_prototype since it's a vector of matrices and make manually passed derivatives take 3 arguments #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

Vaibhavdixit02
Copy link
Member

Fixes #341

@ChrisRackauckas
Copy link
Member

add a test?

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #342 (0bc903b) into master (85af4e4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   12.22%   12.22%           
=======================================
  Files           9        9           
  Lines         270      270           
=======================================
  Hits           33       33           
  Misses        237      237           
Impacted Files Coverage Δ
src/function/finitediff.jl 0.00% <0.00%> (ø)
src/function/forwarddiff.jl 0.00% <0.00%> (ø)
src/function/function.jl 0.00% <ø> (ø)
src/function/mtk.jl 0.00% <0.00%> (ø)
src/function/reversediff.jl 0.00% <0.00%> (ø)
src/function/tracker.jl 0.00% <0.00%> (ø)
src/function/zygote.jl 48.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Vaibhavdixit02 Vaibhavdixit02 changed the title Incorrect convert call for cons_hess_prototype since it's a vector of matrices Incorrect convert call for cons_hess_prototype since it's a vector of matrices and make manually passed derivatives take 3 arguments Aug 17, 2022
@Vaibhavdixit02 Vaibhavdixit02 force-pushed the Vaibhavdixit02-patch-1 branch from 1c4fbcf to 30b6a45 Compare August 17, 2022 12:10
@Vaibhavdixit02 Vaibhavdixit02 force-pushed the Vaibhavdixit02-patch-1 branch from 30b6a45 to 0bc903b Compare August 17, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instantiate_function converts sparse matrix to Float
2 participants