fix: Bedrock support #227
Closed
fix: Bedrock support #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: update instructions to use with LocalAI
Revert "docs: update instructions to use with LocalAI"
Docs main readme
## [0.10.1](ScrapeGraphAI/Scrapegraph-ai@v0.10.0...v0.10.1) (2024-05-11) ### Bug Fixes * crash asyncio due dependency version ([2563773](ScrapeGraphAI@2563773)) ### Docs * fixed speechgraphexample ([4bf90f3](ScrapeGraphAI@4bf90f3)) * fixed unused param and install ([cc28d5a](ScrapeGraphAI@cc28d5a)) * **readme:** improve main readme ([ae5655f](ScrapeGraphAI@ae5655f)) * update instructions to use with LocalAI ([198420c](ScrapeGraphAI@198420c)) * Update README.md ([772e064](ScrapeGraphAI@772e064)) * updated sponsor logo ([f8d8d71](ScrapeGraphAI@f8d8d71))
f-aguzzi
requested changes
May 13, 2024
There was a problem hiding this comment.
I'm not a member of the team, however:
- direct contributions to the
mainbranch are not accepted, as stated in the contributing policy. You have to work on thepre/betabranch (the embedding problem is already fixed in that branch, by the way)
You might still improve two things on that branch too, though:
- look into the duplicate
ClaudeandAnthropicclasses in themodelsfolder (looks like they're doing the same thing) - swap the community
BedrockEmbeddingswith the officialBedrockEmbeddings
| @@ -146,12 +147,12 @@ def _create_llm(self, llm_config: dict, chat=False) -> object: | |||
| except KeyError as exc: | |||
| raise KeyError("Model not supported") from exc | |||
| return Gemini(llm_params) | |||
| elif "claude" in llm_params["model"]: | |||
| elif llm_params["model"].startswith("claude"): | |||
There was a problem hiding this comment.
Good idea, could be used in other points of this file
|
Superseded by #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
Example: https://gist.github.com/JGalego/67a3db0005f5ed052224e549e8ee627c