Skip to content

Test ScriptCreatorGraph and print execution info #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

tejhande
Copy link
Contributor

@tejhande tejhande commented Jun 7, 2024

This commit enhances the test suite for the ScriptCreatorGraph class by improving code readability, adding more informative assertions, and printing the prettified execution information.

Changes:

  • Added more descriptive docstrings for better code documentation.
  • Improved assertion messages to provide better debugging experience in case of failures.
  • Added a line to print the prettified execution information using the prettify_exec_info function.
  • Included a comment to remind developers to add additional assertions on the result or execution info if needed.
  • Fixed a minor typo in the configuration dictionary (beautifulsoup instead of beautifoulsoup).

Benefits:

  • Improved code readability and maintainability with better documentation.
  • Enhanced debugging experience with more informative assertion messages.
  • Easier analysis of the ScriptCreatorGraph execution by printing the prettified execution information.
  • Reminder to add more assertions for comprehensive testing of the ScriptCreatorGraph.
  • Corrected a minor typo to ensure consistency.

The test suite now provides a more user-friendly experience for developers working on the ScriptCreatorGraph class. The printed execution information will aid in debugging and understanding the graph's execution flow, while the improved assertions and documentation will make the test suite more robust and maintainable.

This commit enhances the test suite for the ScriptCreatorGraph class by improving code readability, adding more informative assertions, and printing the prettified execution information.

Changes:
- Added more descriptive docstrings for better code documentation.
- Improved assertion messages to provide better debugging experience in case of failures.
- Added a line to print the prettified execution information using the `prettify_exec_info` function.
- Included a comment to remind developers to add additional assertions on the result or execution info if needed.
- Fixed a minor typo in the configuration dictionary (`beautifulsoup` instead of `beautifoulsoup`).

Benefits:
- Improved code readability and maintainability with better documentation.
- Enhanced debugging experience with more informative assertion messages.
- Easier analysis of the ScriptCreatorGraph execution by printing the prettified execution information.
- Reminder to add more assertions for comprehensive testing of the ScriptCreatorGraph.
- Corrected a minor typo to ensure consistency.

The test suite now provides a more user-friendly experience for developers working on the ScriptCreatorGraph class. The printed execution information will aid in debugging and understanding the graph's execution flow, while the improved assertions and documentation will make the test suite more robust and maintainable.
@VinciGit00
Copy link
Collaborator

hi, we would be glad if you could make tests for all the graphs in ollama

@VinciGit00 VinciGit00 merged commit 2781c3c into ScrapeGraphAI:main Jun 9, 2024
2 checks passed
Copy link

github-actions bot commented Jun 9, 2024

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 9, 2024

🎉 This PR is included in version 1.6.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants