Add the ability to specify load state #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thank you, if you have idea to how to implement the authentication please contact us |
|
Thanks for the merge @VinciGit00 ! Is there an issue for authentication? Happy to take a look |
|
this one url |
|
🎉 This PR is included in version 1.7.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some sites that rely on SPA type of architecture are returning HTML content before the page is properly populated with client side fetched data.
Solution
When working with playwright, depending on the architecture of the scraped site, we may want to wait for different page events before considering a page "loaded" and ready to parse.
This adds the ability to specify
load_state, which defaults todomcontentloadedbut can be overridden with other playwright load states: https://playwright.dev/python/docs/api/class-page#page-wait-for-load-state