Skip to content

Screenshot scraping #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

Santabot123
Copy link
Contributor

@Santabot123 Santabot123 commented Aug 28, 2024

I added the option to extract text from screenshots.
I also made this Google Colab example of how to use it. But I still recommend using this code locally, because the select_area_with_opencv() function allows you to select the area of the screenshot with your mouse, which makes it much more convenient to use.

@VinciGit00
Copy link
Collaborator

btw if you can also make a short video demo where you use the tool it could be useful

return left_right_slider, top_bottom_slider


def crop_image(image, LEFT=None, TOP=None, RIGHT=None, BOTTOM=None, save_path: str = None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, why the uppercase arguments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a nutshell, 3 out of 5 functions that I added are part of my other project and I just forgot to change it.

@Santabot123
Copy link
Contributor Author

btw if you can also make a short video demo where you use the tool it could be useful

I don't have a lot of experience with video editing, but I did my best. Here is the link to youtube.

@DiTo97
Copy link
Collaborator

DiTo97 commented Aug 30, 2024

btw if you can also make a short video demo where you use the tool it could be useful

I don't have a lot of experience with video editing, but I did my best. Here is the link to youtube.

appreciate the effort!

@VinciGit00
Copy link
Collaborator

hi thank you, in the next days we will make a blog post, would you like to be tagged?

@VinciGit00 VinciGit00 changed the base branch from pre/beta to screenshot-scraper-fix August 30, 2024 09:41
@VinciGit00 VinciGit00 merged commit 405f28e into ScrapeGraphAI:screenshot-scraper-fix Aug 30, 2024
@Santabot123
Copy link
Contributor Author

hi thank you, in the next days we will make a blog post, would you like to be tagged?

Yes

@VinciGit00
Copy link
Collaborator

VinciGit00 commented Aug 30, 2024

ok, please give me your LinkedIn account so we can tag you.

@Santabot123
Copy link
Contributor Author

Santabot123 commented Aug 30, 2024

ok, please give me your LinkedIn account so we can tag you.

I don't have a LinkedIn account. I thought you would just write something like “Thank you very much, Santabot123 😎”

@DiTo97
Copy link
Collaborator

DiTo97 commented Aug 30, 2024

yeah, @VinciGit00, maybe just link his GH account

@VinciGit00
Copy link
Collaborator

Ok I will

@@ -0,0 +1,29 @@
from surya.ocr import run_ocr
Copy link
Collaborator

@DiTo97 DiTo97 Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinciGit00, try and place as line 1:

import typing_extensions

Copy link

github-actions bot commented Sep 2, 2024

🎉 This issue has been resolved in version 1.17.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Sep 8, 2024

🎉 This PR is included in version 1.19.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.20.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants