Skip to content

feat(docloaders): Enhance browser_base_fetch function flexibility #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

tuhinmallick
Copy link
Contributor

Enhanced browser_base_fetch Function in DocLoaders

Changes

  • Updated browser_base_fetch function to accept either a single URL or a list of URLs
  • Added text_content parameter to allow choosing between text-only and HTML output
  • Improved type hinting for better code readability and IDE support
  • Updated function documentation to reflect new capabilities

Motivation

These changes enhance the flexibility and usability of the browser_base_fetch function, aligning it more closely with the latest Browserbase SDK interface. This update allows users to more easily fetch content from single or multiple URLs and choose between text-only and HTML output.

Testing

  • Tested with single URL input
  • Tested with multiple URL input
  • Verified text-only and HTML output options

Additional Notes

This update maintains backwards compatibility while extending functionality. Users of the existing interface should experience no disruption, while gaining access to new features.

Related Issues

Closes #[Issue Number] (if applicable)

Please review and let me know if any further changes are needed.

- Update browser_base_fetch to accept single URL or list of URLs
- Add text_content parameter for choosing between text-only and HTML output
- Improve type hinting and function documentation
- Ensure compatibility with latest Browserbase SDK interface
@VinciGit00 VinciGit00 merged commit 7d39019 into ScrapeGraphAI:main Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants