Skip to content

feat(browser_base_fetch): add async_mode to support both synchronous … #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

tuhinmallick
Copy link
Contributor

…and asynchronous execution

  • Introduced an async_mode flag to allow users to choose between synchronous and asynchronous fetching using Browserbase.
  • Refactored common logic (browserbase initialization and result list) to avoid redundancy.
  • Added internal async handling with asyncio.to_thread() for non-blocking execution in async_mode.
  • Maintained backward compatibility for existing synchronous functionality.

tuhinmallick and others added 2 commits September 8, 2024 08:49
…and asynchronous execution

- Introduced an async_mode flag to allow users to choose between synchronous and asynchronous fetching using Browserbase.
- Refactored common logic (browserbase initialization and result list) to avoid redundancy.
- Added internal async handling with asyncio.to_thread() for non-blocking execution in async_mode.
- Maintained backward compatibility for existing synchronous functionality.
@VinciGit00 VinciGit00 merged commit e9a74e1 into ScrapeGraphAI:main Sep 8, 2024
2 checks passed
Copy link

github-actions bot commented Sep 8, 2024

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants