fix:fix boto3 client copy #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinciGit00
reviewed
Sep 14, 2024
From the issue error, copy config happens before initializing AbstractGraph graphs. It only expand the 
|
VinciGit00
approved these changes
Sep 14, 2024
|
🎉 This PR is included in version 1.20.0-beta.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #669
I got it. I follow the boto3 document and find this is diffcult to copy without getting resource. So I try to return same obj.
The resaon is the copy config will pass in the sub graph and the use same client.This means that copying and returning the original object have the same effect.
BTW, I refactor it shallow copy code and pass all test