Skip to content

[🚀 Feature]: Helm chart - ability to specify image pull secrets #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zmconnelly opened this issue Jun 30, 2022 · 2 comments
Closed

[🚀 Feature]: Helm chart - ability to specify image pull secrets #1619

zmconnelly opened this issue Jun 30, 2022 · 2 comments

Comments

@zmconnelly
Copy link
Contributor

zmconnelly commented Jun 30, 2022 •
edited
Loading

Feature and motivation

The ability to specify an image pull secret will allow using custom/caches from a corporate container registry that requires authentication.

In our environment anonymous dockerhub is not an option.

Usage example

values:
  global:
    imagePullSecret: <my-secret>  #default
  chromeNode:
    imagePullSecret: <my-secret>  #override
@zmconnelly zmconnelly changed the title [🚀 Feature]: Ability to specify image pull secrets [🚀 Feature]: Helm chart - ability to specify image pull secrets Jun 30, 2022
zmconnelly added a commit to zmconnelly/docker-selenium that referenced this issue Jun 30, 2022
@zmconnelly
Helm: ability to specify image pull secrets (SeleniumHQ#1619)
9f4d845 
Added global value `global.seleniumGrid.imagePullSecret`
Added per component override `component.imagePullSecret`

Updated readme
Bumped chart version to 0.7.0
@zmconnelly
Copy link
Contributor Author

Opened PR #1620 to address this

zmconnelly added a commit to zmconnelly/docker-selenium that referenced this issue Jul 1, 2022
@zmconnelly
Helm: ability to specify image pull secrets (SeleniumHQ#1619)
3b26d85 
Added global value `global.seleniumGrid.imagePullSecret`
Added per component override `component.imagePullSecret`

Updated readme
Bumped chart version to 0.7.0
zmconnelly pushed a commit to zmconnelly/docker-selenium that referenced this issue Jul 2, 2022
Helm: ability to specify image pull secrets (SeleniumHQ#1619)
62f84ba 
Added global value `global.seleniumGrid.imagePullSecret`
Added per component override `component.imagePullSecret`

Updated readme
Bumped chart version to 0.6.3
diemol pushed a commit that referenced this issue Jul 6, 2022
@zmconnelly
Helm: ability to specify image pull secrets (#1619) (#1620)
e36cc59 
* Helm: ability to specify image pull secrets (#1619)

Added global value `global.seleniumGrid.imagePullSecret`
Added per component override `component.imagePullSecret`

Updated readme
Bumped chart version to 0.7.0

* Helm: ability to specify image pull secrets (#1619)

Added global value `global.seleniumGrid.imagePullSecret`
Added per component override `component.imagePullSecret`

Updated readme
Bumped chart version to 0.7.0
@diemol
Copy link
Member

diemol commented Jul 7, 2022

PR was merged, thanks for your contribution, @zmconnelly!

@diemol diemol closed this as completed Jul 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diemol @zmconnelly