Skip to content

K8s deployment #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2020
Merged

K8s deployment #1113

merged 8 commits into from
Oct 22, 2020

Conversation

sahajamit
Copy link
Contributor

Description

Added the yaml configuration file to deploy the grid 4 alpha release docker images inside a kubernetes environment.

Motivation and Context

I have been using the selenium 4 grid alpha release in my local kubernetes environment and for this purpose I have created the complete deployment yaml to deploy the full grid in k8s environment.

As I could only see the docker-compose yaml file in this repo so I have decided to contribute the kubernetes yaml to this repository so that others can also start using it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sahajamit! This is great!

Could you please add some instructions to the readme, showing how to use it?

@sahajamit
Copy link
Contributor Author

@diemol, I have added the documentation in readme.

@sahajamit sahajamit requested a review from diemol October 2, 2020 08:34
@sahajamit
Copy link
Contributor Author

@diemol: Can you please help merging this PR ?

@diemol
Copy link
Member

diemol commented Oct 9, 2020

@sahajamit I haven't had time to test it.
A way to help me test it would be to add a GitHub action that starts minikube and uses this k8s configuration to start the Grid and run a couple of tests.

@sahajamit
Copy link
Contributor Author

@diemol : Sure let me setup a Github action and will revert back in couple of days.

@sahajamit
Copy link
Contributor Author

@diemol : I have added a github action which will spin up a minikube cluster, deploy the grid4 and also do a simple smoke test. Pls let me know if any other test needs to be added.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sahajamit! This is great 🎉

@diemol diemol merged commit deadadd into SeleniumHQ:trunk Oct 22, 2020
@sahajamit sahajamit deleted the k8s-deployment branch November 20, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants