Skip to content

Update the ubuntu base image to bionic-20201119 #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

VinodAnandan
Copy link
Contributor

@VinodAnandan VinodAnandan commented Dec 3, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VinodAnandan!

@diemol diemol merged commit ab99bbd into SeleniumHQ:trunk Dec 3, 2020
@VinodAnandan VinodAnandan deleted the patch-1 branch December 3, 2020 13:40
@Iryna-
Copy link

Iryna- commented Dec 7, 2020

@diemol thank you for reviewing the change. Would that be possible to trigger a build and upload to the dockerhub for this version?

@Iryna-
Copy link

Iryna- commented Jan 5, 2021

sorry to disturb you again @diemol , is there any chance this version could be built and become available on DockerHub?

@diemol
Copy link
Member

diemol commented Jan 5, 2021

@Iryna-, sorry, I missed the previous comment.

These images were released a while ago for the Selenium 4 Grid. Maybe you are referring to the Grid 3 ones? For Grid 3 images we are keeping the changes to a minimum and only releasing new browser versions. If you have more questions, feel free to drop by our Slack/IRC channels, links can be seen here.

@Iryna-
Copy link

Iryna- commented Jan 5, 2021

Thank you for getting back to me @diemol (sorry, I don't have Slack). Yes, I was hoping to get this in the image for Grid v3.141.59 on DockerHub

@diemol
Copy link
Member

diemol commented Jan 5, 2021

No need for Slack, you can also use IRC, https://webchat.freenode.net/#selenium

We are soon upgrading to Ubuntu 20.04, I can try to update Grid 3 images as well, hopefully that works for you.

@Iryna-
Copy link

Iryna- commented Jan 5, 2021

Yeah, I did try the IRC, but getting This site can’t be reached from where I am 😕 . That would be great if we could get Grid 3 upgraded as well if it's not too big of a hassle, thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants