Skip to content

Bump actions-setup-minikube to v2.3.0 #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

manusa
Copy link
Contributor

@manusa manusa commented Jan 5, 2021

Description

Upgrade manusa/actions-setup-minikube to use the latest version.

Motivation and Context

GitHub is rolling out Ubuntu 20.04 as the default environment. GitHub actions workflows using ubuntu-latest will soon start an Ubuntu 20,04 instance instead of 18.04.

Prior versions of manusa/actions-setup-minikube have a check which won't allow the workflow job to run. Starting on 2.2.0, Ubuntu 20.04 is supported too (manusa/actions-setup-minikube#26).

Relates to #1169

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other:

  • Non-breaking CI dependency upgrade

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2021

CLA assistant check
All committers have signed the CLA.

@diemol
Copy link
Member

diemol commented Jan 6, 2021

@manusa, could you please sign the CLA and I can merge this right away?

@manusa
Copy link
Contributor Author

manusa commented Jan 6, 2021

I think I signed it yesterday, not sure if there's Some sort of manual step on your side?

@manusa
Copy link
Contributor Author

manusa commented Jan 6, 2021

Ok, it seems I signed some other form

@diemol
Copy link
Member

diemol commented Jan 6, 2021

Thank you, @manusa!

@diemol diemol merged commit f9c1573 into SeleniumHQ:trunk Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants