Support to MicrosoftEdge on chromium #1202
Conversation
|
|
There was a problem hiding this comment.
Thanks for this, @v1-wizard!
I haven't reviewed everything, but it looks good!
Seems that the commits are not associated with your GitHub user, could you please figure that out, sign the CLA, and then we can start working on merging this?
|
Please disregard my previous comment, I see you already fixed it. |
|
@diemol hi, nice to meet you. I see that one of the test is failed, but actually |
* Upload artifact with edge_video was added to workflows
|
Sure, let me have a look and see what is going on. I probably need a couple of days to finish something first. |
* The selecting of right driver version for edge was fixed
* timeout to waiting pod of selenium-chrome-node was apped in k8s-deploy-test
|
@diemol Hi, I found and fixed whole problem with tests. =) |
😆 I just saw the commit that made the tests pass, sometimes it is the little things! Thank you for taking the time and making all tests pass! I will merge this soon. |
|
I need to correct some dates, and then I will release new images tomorrow. |
* Images for MicrosoftEdge with chromium was added. * Example for StandaloneEdge was added. * Documentation was fixed according to changes. * * Timeout to waiting pods was upped * Upload artifact with edge_video was added to workflows * * Timeout to waiting pods was returned back * The selecting of right driver version for edge was fixed * * Rebuild without cache to update image after fix * * Dockerfile was regenerated * * Add missed dependencies to edge targets in Makefile * * Up version * * test_video was fixed * timeout to waiting pod of selenium-chrome-node was apped in k8s-deploy-test * Update README.md * Update README.md Co-authored-by: Diego Molina <[email protected]>
Description
This PR adds support to MicrosoftEdge containerization.
Motivation and Context
MicrosoftEdgewithtestcontainersin my project for testing.Types of changes
Checklist