-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
helm: add lifecycle preStop hook & startupProbe, fix port number #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you please update your fork and also update the values in Chart.yaml? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nefelim4ag mind to check a few suggestions, thanks
…alues.yaml * Fix typos in templates Co-authored-by: Vadim Grek <[email protected]> * Resolve conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @nefelim4ag!
Summary:
Motivation and Context
Without a lifecycle preStop hook autoscaling is a huge problem (pod will die - test will fail), so just add instrumentation to define one and change the termination grace period.
startupProbe - just for observability purposes, the pod will be shown as ready only when it ready to work
Types of changes
Checklist
#1592