Skip to content

helm: add lifecycle preStop hook & startupProbe, fix port number #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

nefelim4ag
Copy link
Contributor

@nefelim4ag nefelim4ag commented Jun 21, 2022

Summary:

  • Allow define lifecycle hooks & add a working example
  • Allow override termination gracePeriod
  • Allow defining startupProbe
  • Fix port number in values

Motivation and Context

Without a lifecycle preStop hook autoscaling is a huge problem (pod will die - test will fail), so just add instrumentation to define one and change the termination grace period.

startupProbe - just for observability purposes, the pod will be shown as ready only when it ready to work

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

#1592

@diemol
Copy link
Member

diemol commented Jul 1, 2022

Could you please update your fork and also update the values in Chart.yaml?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Copy link

@brainiac84 brainiac84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nefelim4ag mind to check a few suggestions, thanks

…alues.yaml

* Fix typos in templates
Co-authored-by: Vadim Grek <[email protected]>
* Resolve conflicts
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nefelim4ag!

@diemol diemol merged commit aa55ed1 into SeleniumHQ:trunk Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants