Skip to content

Fixed parsing problem with msedgedriver version in release notes #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

jamesmortensen
Copy link
Member

Fixed parsing problem with msedgedriver version in release notes generator script and docker image tagging script.

Fixes #1641 where the msedgedriver version was not parsed correctly in release notes and when pushing tags to Docker Hub.

Description

msedgedriver version output looks like this:

$ docker run --rm selenium/node-edge:4.4.0-20220815 msedgedriver --version
Microsoft Edge WebDriver 104.0.1293.54 (cf00dc8720d894eb5f0a1b840990bb9ecf8b3589)

When trying to parse the version, we were pulling from the second column. At some point, Microsoft must have changed the location of the version number to the 4th column. Using the 4th column, we get the version:

docker run --rm selenium/node-edge:4.4.0-20220815 msedgedriver --version | awk '{print $4}'
104.0.1293.54

Motivation and Context

This ensures release notes have the correct version, and that the Docker Hub tags have the correct driver version applied to them.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…rator script and docker image tagging script.
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesmortensen!

@diemol diemol merged commit fe89258 into SeleniumHQ:trunk Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: EdgeDriver version is not correctly displayed in release notes
2 participants