Skip to content

Patch 2 #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

StevenBOULLE
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol and others added 30 commits January 17, 2023 11:04
Change rights to 775
Change rights
Change group of directories "/opt/selenium ${HOME} /opt/selenium/assets /var/run/supervisor /var/log/supervisor" to group seluser
Usage of ACL to stay with root's rights for user and group but add some rights to user seluser with ACL
* Fix CHANGELOG overwrite

* Bump Chart version to 0.15.0
* Bump to 0.15.1 for 4.8.0-20230131

* Fix CHANGELOG overwrite
…dated them (SeleniumHQ#1787)

Using release tag instead of commit-id on novnc and websockify and updated both to the latest version

[deploy]
Adding sudo to avoid "permission denied" messages
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ StevenBOULLE
✅ luisfcorreia
✅ diemol
✅ abaldwin-op
✅ jsa34
✅ AndreasPetersen
✅ adrianhj
✅ budtmo
❌ selenium-ci
You have signed the CLA already but the status is still pending? Let us recheck it.

@StevenBOULLE
Copy link
Contributor Author

@diemol CI Pipeline looks OK, can you check and validate the merge request ?

@diemol
Copy link
Member

diemol commented Feb 21, 2023

Duplicate of #1773

@diemol diemol marked this as a duplicate of #1773 Feb 21, 2023
@diemol diemol closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants