Pin the Firefox version to 45 #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ RUN apt-get update -qqy \ | |||
| sudo \ | |||
| unzip \ | |||
| wget \ | |||
| bzip2 \ | |||
There was a problem hiding this comment.
The list of packages to install is sorted alphabetically to minimize the risk of merge conflicts.
|
I would try to stay away from updating the tags, unless we really need it. If a new Selenium version requires a new Firefox version, we just need to make sure that with the upgrade of Selenium the Firefox version will be changed as well. |
|
@kayabendroth updated based on review feedback |
|
@davehunt Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Firefox 46 is released, the current FirefoxDriver will stop working. Currently, the latest stable version of Firefox at the time the image was build is installed. This means if it's rebuilt, the version might update beyond Firefox 45, but it also means if it's not rebuilt an old and unsupported version of Firefox may be used.
This patch explicitly installs Firefox 45.0.1, and allows more purposeful updates of the browser. It will also allow us to manage Firefox 46 and adding support for Marionette.
Something I'm not clear on is the tags. I've changed them to 'latest' for the affected images because they require the upstream changes, but I'm not sure how this should affect users of the tags. Should updating Firefox mean also updating the tags? Perhaps tags could be the Selenium version plus a point release for each image, such as
2.52.0.1and include a changelog to indicate what's new?