Skip to content

adding chart ingress namespace field #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IronMage
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Selenium Grid chart does not include the release namespace in the object definition, causing it to be deployed to the default namespace rather than the target namespace.

Motivation and Context

Deploying with the helm --namespace flag causes the ingress to potentially be deployed to a different namespace.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Cody Lent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@diemol
Copy link
Member

diemol commented Oct 3, 2023

@IronMage could you please sign the CLA?

@IronMage
Copy link
Contributor Author

IronMage commented Oct 3, 2023

@IronMage could you please sign the CLA?

This has been signed. Could've been an issue with an email missing; that has been fixed.

@diemol
Copy link
Member

diemol commented Oct 3, 2023

Your commit does not have the email associated.

@IronMage
Copy link
Contributor Author

IronMage commented Oct 3, 2023

@diemol See #1966 instead.

@IronMage IronMage closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants